Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Aerogarden API v4 #33

Merged
merged 4 commits into from
May 2, 2024
Merged

Target Aerogarden API v4 #33

merged 4 commits into from
May 2, 2024

Conversation

dalinicus
Copy link
Owner

Switch from https://app3.aerogarden.com:8443 to https://app4.aerogarden.com

  • fixes issue Investigate app4.aerogarden.com #32 where v3's certificate is now invalid, but v4 appears to be working. Should resolve issues with connecting to the aerogarden api.
  • fix a couple logging lines that were throwing errors
  • refactor miscellaneous code smells and misspellings

update url from app3 to app4 to fix invalid cert issue
fix tests due to changes in hass core regarding configentry
fix edge case with setting config when interval is None
assorted linting fixes
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3557a38) to head (d9fe536).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          334       335    +1     
=========================================
+ Hits           334       335    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalinicus dalinicus merged commit d03d3fc into main May 2, 2024
13 checks passed
@dalinicus dalinicus deleted the bugfix/bad-aerogarden-api branch May 2, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant