New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda function for out_of_vocabulary_token_option #24

Open

keshprad wants to merge 5 commits into daltonfury42:master from keshprad:master

+42 −10

Contributor

keshprad commented Jul 3, 2021 •

edited

Loading

This is a solution for lambda function feature request in #23

Created out_of_vocabulary_handler
- Added ability to handle lambda function
  - the lambda function gets token_og_case, which has the original casing
- I realized that the current release is implicitly using .lower() if an invalid option for out_of_vocabulary_token_option is passed (eg: out_of_vocabulary_token_option = 'upper')
  - This is due to L128.
  - I'm now passing the token with original casing to the handler function. If an invalid option is passed, I will use .title()
Added test case for lambda function.
Updated README for out_of_vocab options

keshprad added 5 commits

July 3, 2021 10:24


          create out_of_vocab_handler function

9f35f8b


          Implement lambda func for out_of_vocab option

f74c804


          add lambda func test case & update readme for out_of_vocab

e0546c6


          fixed error in readme

afaa96c


          Use title if invalid out of vocab option passed

bbd9c42

Contributor Author

keshprad commented Jul 3, 2021

PR isn't ready to merge yet. I'm unsure how to address this, but would be a quick fix after we discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet