-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin header should be optional and settable #151
Comments
This is a good point and thanks for linking to the RFC. I agree it should be settable, just want to be careful we don't break any currently working clients by removing the origin header that is sent now. I think we should test some common web socket servers with this change to ensure everything is good before we merge #152. |
Good point. Although testing is always important maybe we can also set the previous hardcoded value as the default value for the new variable to keep the backward compatibility. What you think? |
I like that idea of the default value. You want to add it your PR and we can merge it? |
Done |
According to the RFC:
The text was updated successfully, but these errors were encountered: