Fixes #399 String.characters.count deprecation warning in Xcode 9.1 #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.characters.count deprecation warnings
fassko
changed the title
dfed
reviewed
Oct 9, 2017
| @@ -531,7 +531,7 @@ open class WebSocket : NSObject, StreamDelegate, WebSocketClient, WSStreamDelega | |||
| request.setValue("\(url.host!):\(port!)", forHTTPHeaderField: headerWSHostName) | |||
|
|
|||
| var path = url.absoluteString | |||
| let offset = (url.scheme?.characters.count ?? 2) + 3 | |||
| let offset = (url.scheme?.count ?? 2) + 3 | |||
There was a problem hiding this comment.
This change will break for anyone not yet on Xcode 9. Might be best to do the following instead:
#if swift(>=3.2)
let offset = (url.scheme?.count ?? 2) + 3
#else
let offset = (url.scheme?.characters.count ?? 2) + 3
#endif
There was a problem hiding this comment.
Nevermind just saw we're already Swift 4 🙂
There was a problem hiding this comment.
This deprecation message actually is only in Xcode 9.1 but let's get ready for it. ;)
fassko
changed the title
|
Thanks! Let us get ahead of the curve for once 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.characters.count deprecation warnings