Check if self is nil in infinite while loop. #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hDetail method to ErrorHandle struct.
hemangshah
approved these changes
Jan 1, 2018
|
@daltoniam could you please review this pr ? |
|
Thanks! I had another branch going with some other fixes so I just pulled this code into version 3.0.4 which I just released! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move duplicated errorWithDetail method to ErrorHandle struct.
Our ios application uses socket in a way that it closes the connection when the application will resign active and establish the new connection when application did become active. That means we're extensively close and open connection while monkey testing (pressing home button causes to resign active and become active). This patch creates a short circuit to infinite while loop if web socket stream was nil-ed. More importantly, this prevents new socket connection to being connected somehow.