-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/last updated by annotation #138
Feature/last updated by annotation #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, added a few comments. Also please squash the commits and only push a single commit. We try to adhere to similar standards to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few more comments
…ds/modifies a last-updated-by annotation on every creation/update of Capp Signed-off-by: Ariel Septon <64063409+arielsepton@users.noreply.github.com>
2ca6a6a
to
67e2817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arielsepton, mzeevi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a mutating webhook to manage the
rcs.dana.io/last-updated-by
annotation onCapp
objects, tracking user-initiated changes.The mutating webhook only performs the annotation adding for CREATE and UPDATE operations. DELETE operations are allowed without modification since mutation webhooks do not perform any mutations on delete operations.
References: