Watch changes on storage and change state (closes #27) #30
Conversation
|
|
||
| useEffect(() => { | ||
| window.addEventListener('storage', handleStorage); | ||
| return () => window.removeEventListener('storage', handleStorage); |
There was a problem hiding this comment.
If value changes, causing handleStorage callback to change, will removeEventListener still work here then? 🤔
There was a problem hiding this comment.
It will remove and append again in the next cycle.
|
Thank you @VitorLuizC for the PR (turn off notifications w/ checking 😓) and @Svish for the review. |
|
Thank you again, @VitorLuizC. |
|
@all-contributors please add @Svish for review |
|
I've put up a pull request to add @Svish! 🎉 |
|
@dance2die Really not sure my question counts as a contribution, but up to you guys, hehe 😛 |
|
You were able to come up with the question because you read the code, spending your own time @Svish. And also the question was insightful, as I was wondering about it as well. |
I added a listener on storage that runs when modifying storage in another window or tab and an effect that runs on all cycles. Both change state if storage changes occur.
closes #27