reworked exception handling

dancier · Dec 27, 2023 · 19004e3 · 19004e3
1 parent befbdc9
commit 19004e3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 28 deletions.
diff --git a/.../dancer/eventlog/ScheduleMessagePort.java → ...cier/dancer/core/ScheduleMessagePort.java b/.../dancer/eventlog/ScheduleMessagePort.java → ...cier/dancer/core/ScheduleMessagePort.java
@@ -1,4 +1,4 @@
-package net.dancier.dancer.eventlog;
+package net.dancier.dancer.core;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import io.cloudevents.CloudEvent;
@@ -9,6 +9,6 @@ public interface ScheduleMessagePort {
     void schedule(Object object,
                   String key,
                   URI source,
-                  String type) throws JsonProcessingException;
+                  String type);
 
 }
diff --git a/src/main/java/net/dancier/dancer/core/events/ApplicationEventListener.java b/src/main/java/net/dancier/dancer/core/events/ApplicationEventListener.java
@@ -2,22 +2,17 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import io.cloudevents.CloudEvent;
-import io.cloudevents.core.builder.CloudEventBuilder;
 import jakarta.transaction.Transactional;
 import lombok.RequiredArgsConstructor;
-import net.dancier.dancer.eventlog.ScheduleMessagePort;
+import net.dancier.dancer.core.ScheduleMessagePort;
 import net.dancier.dancer.eventlog.service.EventlogService;
-import net.dancier.dancer.messaging.ScheduleMessageAdapter;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.context.ApplicationContextException;
 import org.springframework.context.event.EventListener;
 import org.springframework.stereotype.Component;
 
 import java.net.URI;
-import java.time.OffsetDateTime;
-import java.util.UUID;
 
 @Component
 @RequiredArgsConstructor
@@ -44,18 +39,12 @@ public void handle(ProfileUpdatedEvent profileUpdatedEvent) {
                 eventCreator.createEventlog(
                         "profile-updated",
                         profileUpdatedEvent.getDancer()));
-        try {
-            String tmp = objectMapper.writeValueAsString(profileUpdatedEvent);
-            System.out.println(tmp);
             scheduleMessagePort.schedule(
                     profileUpdatedEvent,
                     profileUpdatedEvent.getDancer().getId().toString(),
                     BACKEND_SOURCE,
                     "profile-updated");
-        } catch (JsonProcessingException jpe) {
-            log.error("Unable to generate Cloud-Event for: " + profileUpdatedEvent, jpe);
-            throw new ApplicationContextException("Unable to create Json", jpe);
-        }
+
     }
 
 }
diff --git a/src/main/java/net/dancier/dancer/eventlog/controller/EventlogController.java b/src/main/java/net/dancier/dancer/eventlog/controller/EventlogController.java
@@ -1,7 +1,6 @@
 package net.dancier.dancer.eventlog.controller;
 
 import lombok.RequiredArgsConstructor;
-import net.dancier.dancer.eventlog.ScheduleMessagePort;
 import net.dancier.dancer.eventlog.dto.EventlogMapper;
 import net.dancier.dancer.eventlog.dto.NewEventlogDto;
 import net.dancier.dancer.eventlog.model.Eventlog;

diff --git a/src/main/java/net/dancier/dancer/eventlog/service/EventPublisherJob.java b/src/main/java/net/dancier/dancer/eventlog/service/EventPublisherJob.java
@@ -1,7 +1,6 @@
 package net.dancier.dancer.eventlog.service;
 
 import lombok.RequiredArgsConstructor;
-import net.dancier.dancer.eventlog.ScheduleMessagePort;
 import net.dancier.dancer.eventlog.model.Eventlog;
 import net.dancier.dancer.eventlog.repository.EventlogDAO;
 import net.dancier.dancer.eventlog.repository.EventlogStatus;

diff --git a/src/main/java/net/dancier/dancer/messaging/ScheduleMessageAdapter.java b/src/main/java/net/dancier/dancer/messaging/ScheduleMessageAdapter.java
@@ -3,23 +3,15 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import io.cloudevents.CloudEvent;
-import io.cloudevents.core.builder.CloudEventBuilder;
-import io.cloudevents.core.data.PojoCloudEventData;
-import io.cloudevents.core.provider.EventFormatProvider;
-import io.cloudevents.jackson.PojoCloudEventDataMapper;
 import lombok.RequiredArgsConstructor;
-import net.dancier.dancer.eventlog.ScheduleMessagePort;
+import net.dancier.dancer.core.ScheduleMessagePort;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.kafka.core.KafkaTemplate;
+import org.springframework.context.ApplicationContextException;
 import org.springframework.stereotype.Component;
 
 import java.net.URI;
 import java.time.OffsetDateTime;
-import java.util.UUID;
-
-import static io.cloudevents.core.CloudEventUtils.mapData;
 
 @RequiredArgsConstructor
 @Component
@@ -35,7 +27,7 @@ public class ScheduleMessageAdapter implements ScheduleMessagePort {
     public void schedule(Object object,
                          String key,
                          URI source,
-                         String type) throws JsonProcessingException {
+                         String type) {
         log.info("sending object: " + object);
         log.info("with key:" + key);