🐛 Empty lines highlight plus-marker as whitespace-error

[Nemo157]

With a test file:

No Spaces

Spaces
  

(Note that there are spaces on the last line)

Running

delta --no-gitconfig --keep-plus-minus-markers <(echo -n) test-file

highlights the plus-marker on the empty line as a whitespace error

[Kr1ss-XD]

I guess it is a whitespace error diff, since newlines are whitespace, no ?

[Nemo157]

It's very distracting having it highlighted in the middle of a block, and it's inconsistent with what git itself highlights as whitespace errors:

[Kr1ss-XD]

It's very distracting having it highlighted in the middle of a block

Agreed, though one could also argue that it might be advantageous to have whitespace diffs highlighted esp. when working with languages as python where they are crucial

it's inconsistent with what git itself highlights as whitespace errors

That depends on the configuration. Not sure though what the defaults are, to be honest, but IIRC git does highlight such a diff without any config.

EDIT/ This was after removing all git config files :

Anyways, I agree it would be quite handy to have it configurable in delta, too.

[dandavison]

Hi @Nemo157, thanks for this!

@Kr1ss-XD what @Nemo157 is pointing out is that completely normal, not-at-all-an-error blank lines are being styled with an error background color when using keep-plus-minus-markers. I would say this is definitely a bug!

[Kr1ss-XD]

Oh, I see. I've missed the point then I guess.

[ericbn]

I think this is part of a bigger issue, as I reported in #345.

[dandavison]

@Nemo157 thanks for this, it is fixed in master (unreleased).

@ericbn thanks for pointing out the link to #345. The fix that has been merged for this branch fixes a subset of the bugs you demonstrated in #345, but not all.

[dandavison]

This fix is released now (v0.4.5).