-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Some theme options are not working with --color-only
enabled
#405
Comments
Hi @renard, thanks for this! Short answer: yes, I think there are more improvements we can make to Until recently, there had been some bugs causing
cc @ulwlu what do you think? |
Hi, my thought is same.
0-1 are true, maybe I can look into it to make |
Thanks @ulwlu, that would be fantastic if you have time. |
P.S. Currently, I'm busier than I expected so not working yet. -- P.S. 2020-11-29 Sorry again, but still quite busy with my job. |
Hi, I'm currently working on this, however, doesn't Even though
-- I realized this is a bug from tests. |
Thanks @ulwlu! I noticed this yesterday but didn't have a chance to fix. Fixed now I believe. ed39e4c Now, what I need to work out is why CI was not failing. Locally, the shell scripts exit with a non-zero error status. cc @MarcoIeni (but you don't have any obligations after all your work! :) ) |
I think CI succeeds because it passes argument. |
@ulwlu Let's discuss in #421 |
… (#436) * Add config property of color_only * Delete force assign raw to file_style when color_only * Print filemeta in color with rawline when color_only mode * Cargo fmt * Add test if file_style with color_only has style * Add comment about color_only
…only #405 (#437) * Remove force passing raw to hunk header style when color_only * Handle hunk header color when color_only * Add test for hunk header style color when color_only * Delete fixme because it actually is required * Add comment for condition that keeps structure when color_only and raw mode
@ulwlu' fixes are released now (v0.4.5). |
@dandavison ps |
When running
delta
in a standalone mode (no git) with--color-only
to keep a diff / patch compatible patch some theming options such as--file-style
or--hunk-header-style
(same with--hunk-header-decoration-style
) are not operational:Is there a way to highlight file headers and hunks delimiter in a specific colour?
Diff file:
TIA.
The text was updated successfully, but these errors were encountered: