Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Git 2.37 workaround from install docs #1228

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

adamchainz
Copy link
Contributor

The bug was fixed in Git 2.38, as noted on original issue: #1114 (comment)

I guess we can remove this from the docs now, so new users don’t switch to the old interactive add.

I thought of adding a section “If you’re using Git 2.37...” but that seemed too specific. If anyone encounters the error, hopefully they’ll search for it and see they need to upgrade Git.

@adamchainz
Copy link
Contributor Author

It also seems the workaround was never added to the docs: https://github.com/dandavison/delta/blob/master/manual/src/get-started.md

Perhaps removing the GitHub README and pointing only to the docs site would be a good idea, to reduce redundant redundancy (that is redundant).

@dandavison dandavison merged commit 5ce2efb into dandavison:master Nov 5, 2022
@dandavison
Copy link
Owner

Thanks @adamchainz! I agree. I think I do like having the quick start instructions in the Github README landing page so that people who are used to installing and configuring things like this can do it very quickly without any clicking around.

@adamchainz adamchainz deleted the patch-1 branch November 5, 2022 13:00
@adamchainz
Copy link
Contributor Author

Thanks for the fast review. Fair enough on keeping on GitHub.

ahmedelgabri added a commit to ahmedelgabri/dotfiles that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants