Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to detect the dark theme from the OS instead of terminal #1661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kornelski
Copy link

I've added an alternative light/dark theme detection mechanism for macOS. It checks the global theme setting, which doesn't require any special terminal support, assuming the terminal application follows the OS theme too.

@bash
Copy link
Contributor

bash commented Mar 25, 2024

Hi @kornelski 👋🏼 It's really cool to see someone continuing on top of my PR :)

What's the reason for detecting the color scheme from the OS instead of the terminal?

If you have any feedback for the terminal color detection I'd love to know 😀

If it's about the latency of the terminal detection then I totally understand; some terminals take quite a moment to answer 😅

@kornelski
Copy link
Author

The reason is that it's completely terminal-independent, so it can work when piping to a non-terminal, or when the terminal itself doesn't support detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants