Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make relative-paths work with binary files #1740

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Make relative-paths work with binary files #1740

merged 3 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. gitignore: add pending insta snapshots

    @th1000s
    th1000s committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    84f1ee2 View commit details
    Browse the repository at this point in the history

  2. Make relativize_path_maybe directly update the path argument 

    This simplifies the call sites.
Also skip updating if the path is already absolute, and handle
'/dev/null' on Windows so it is no longer converted to '\dev\null'.
    @th1000s
    th1000s committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    159ad08 View commit details
    Browse the repository at this point in the history

  3. Make relative-paths work with binary files 

    `relativize_path_maybe()` was not called in this case. Added
test and converted a few existing ones to insta.
    @th1000s
    th1000s committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ce02461 View commit details
    Browse the repository at this point in the history