Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary URLs in installation section of manual (#1810) #1832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dvermd
Copy link

@dvermd dvermd commented Aug 28, 2024

Calling bump-version-in-documentation before create-github-release should fix the issue

Signed-off-by: dvermd <315743+dvermd@users.noreply.github.com>
@dandavison
Copy link
Owner

Hi @dvermd. If we call bump-version-in-documentation before create-github-release then the download links will (at least for a short period of time) be pointing to binaries that do not exist. I think it's better to keep the current order and update the links only once the release builds have been confirmed to be successful and the new binaries are in place.

@dvermd
Copy link
Author

dvermd commented Sep 12, 2024

The documentation will indeed be updated before the release but it is only locally before create-github-release wil create the tag and push the commit and push the tag.

What was your thought on addressing this update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants