Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style strings #204

Merged
merged 21 commits into from
May 26, 2020
Merged

Style strings #204

merged 21 commits into from
May 26, 2020

Conversation

dandavison
Copy link
Owner

@dandavison dandavison commented May 26, 2020

See pre-release write-up in #205.

This is a major refactoring introducing consistent style (foreground, background, style attributes) configuration for all styleable elements. It should close several issues related to foreground and background color configuration, and diff-highlight / diff-so-fancy emulation.

https://git-scm.com/docs/git-config#Documentation/git-config.txt-color

- Support "syntax" pseudo foreground color
- Delete the --syntax-highlight CLI option
  This was never released.
- Do not apply foreground syntax style if it is "null syntect style"
  This isn't really correct. We should find either a valid sentinel
  value, or a way to only do the superimposing when we're doing
  syntax-highlighting.
- Add --zero-style option (style for unchanged hunk lines)
- Implement --color-only using an option rewrite rule
@dandavison dandavison merged commit d2b7fdc into master May 26, 2020
@dandavison dandavison deleted the style-strings branch May 26, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant