Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine refactor #477

Merged
merged 26 commits into from
Dec 28, 2020
Merged

State machine refactor #477

merged 26 commits into from
Dec 28, 2020

Conversation

dandavison
Copy link
Owner

@dandavison dandavison commented Dec 28, 2020

Pure refactoring, no functional changes. cc @ulwlu you might appreciate this! I'm hoping this will make it easier for us to work on parsing features, for example #426, #174, #152, #141, #189.

I'll merge this as squash-and-merge, but the branch contains a series of commits just in case we need to bisect them.

@dandavison dandavison merged commit b9e577a into master Dec 28, 2020
@dandavison dandavison deleted the state-machine-refactor branch December 28, 2020 15:45
@ghost
Copy link

ghost commented Dec 28, 2020

Great! It would be really helpful to add new features.
Sorry I added many unclean codes, I should have done this... Thank you very much.

@dandavison
Copy link
Owner Author

@ulwlu haha no it's not your fault, I've been wanting to improve that mess for more than a year! What I've been meaning to say to you is thank you for all the extra test coverage that allows us to refactor like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant