State machine refactor #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! It would be really helpful to add new features. |
|
@ulwlu haha no it's not your fault, I've been wanting to improve that mess for more than a year! What I've been meaning to say to you is thank you for all the extra test coverage that allows us to refactor like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactoring, no functional changes. cc @ulwlu you might appreciate this! I'm hoping this will make it easier for us to work on parsing features, for example #426, #174, #152, #141, #189.
I'll merge this as squash-and-merge, but the branch contains a series of commits just in case we need to bisect them.