Remove trailing \r from raw line, in presence of ANSI escape sequences #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Nov 25, 2021
| // Thus byte_lines library can't remove the CR properly.) | ||
| if let Some(b'\r') = self.line.bytes().nth_back(0) { | ||
| self.line.truncate(self.line.len() - 1); | ||
| } | ||
| } |
There was a problem hiding this comment.
I owe some tests, but we can see that with this commit we are still fixing the git add -p bug #664 that was the reason for the addition of the lines above (now deleted and replaced by the lines further above):
git add a.py && git commit -m .
mv b.py a.py
Without any \r-stripping, notice that one of the lines is not rendered due to the \r:
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #795 cc @th1000s