Update log message in validate_version_metadata

Also add test to check that versions validated with a status besides
`PENDING` are skipped

dandiapi/api/services/metadata/__init__.py

@@ -172,7 +172,7 @@ def _get_version_validation_result(
         # If the version has since been modified, return early
         if current_version.status != Version.Status.PENDING:
             logger.info(
-                'Skipping validation for version %s due to concurrent modification', version_id
+                'Skipping validation for version with a status of %s', current_version.status
             )
             return
 

dandiapi/api/tests/test_tasks.py

@@ -210,6 +210,26 @@ def test_validate_version_metadata(draft_version: Version, asset: Asset):
     assert draft_version.modified > old_modified
 
 
+@pytest.mark.django_db()
+def test_validate_version_metadata_non_pending_version(draft_version: Version, asset: Asset):
+    # Bypass .save to manually set an older timestamp, set status to INVALID
+    old_modified = timezone.now() - datetime.timedelta(minutes=10)
+    updated = Version.objects.filter(id=draft_version.id).update(
+        modified=old_modified, status=Version.Status.INVALID, validation_errors=['foobar']
+    )
+    assert updated == 1
+
+    draft_version.refresh_from_db()
+    old_validation_errors = draft_version.validation_errors
+    tasks.validate_version_metadata_task(draft_version.id)
+    draft_version.refresh_from_db()
+
+    # Assert fields not updated
+    assert draft_version.status == Version.Status.INVALID
+    assert draft_version.validation_errors == old_validation_errors
+    assert draft_version.modified == old_modified
+
+
 @pytest.mark.django_db()
 def test_validate_version_metadata_no_side_effects(draft_version: Version, asset: Asset):
     draft_version.assets.add(asset)