WIP: Fix RET503 Missing explicit return at the end of function able…

… to return non-`None` value
dandi · Nov 29, 2023 · c676bcf · c676bcf
1 parent 366a9a3
commit c676bcf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/dandiapi/api/admin.py b/dandiapi/api/admin.py
@@ -142,6 +142,7 @@ def queryset(self, request, queryset):
         status = self.value()
         if status:
             return queryset.filter(status=status)
+        return None
 
 
 @admin.register(Version)

diff --git a/dandiapi/api/models/asset.py b/dandiapi/api/models/asset.py
@@ -214,6 +214,8 @@ def sha256(self):
             return self.blob.sha256
         elif self.is_embargoed_blob:
             return self.embargoed_blob.sha256
+        else:
+            raise RuntimeError('Zarr does not support SHA256')
 
     @property
     def digest(self) -> dict[str, str]:

diff --git a/dandiapi/api/views/asset.py b/dandiapi/api/views/asset.py
@@ -167,6 +167,8 @@ def download(self, request, *args, **kwargs):
                 )
 
             return HttpResponseRedirect(url)
+        else:
+            raise TypeError('Invalid content_disposition: %s', content_disposition)
 
     @swagger_auto_schema(
         method='GET',