Merge pull request #1489 from dandi/ignore-assets-summary-failures

dandi · Feb 13, 2023 · e538de6 · e538de6
2 parents 1aefead + 3b51b5d
commit e538de6
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/dandiapi/api/services/metadata/__init__.py b/dandiapi/api/services/metadata/__init__.py
@@ -73,9 +73,14 @@ def version_aggregate_assets_summary(version: Version):
     if version.version != 'draft':
         raise VersionHasBeenPublished()
 
-    version.metadata['assetsSummary'] = aggregate_assets_summary(
-        version.assets.values_list('metadata', flat=True).iterator()
-    )
+    try:
+        version.metadata['assetsSummary'] = aggregate_assets_summary(
+            version.assets.values_list('metadata', flat=True).iterator()
+        )
+    except Exception:
+        # The assets summary aggregation may fail if any asset metadata is invalid, skip
+        # updating it if it fails.
+        logger.info('Error calculating assetsSummary', exc_info=True)
 
     Version.objects.filter(id=version.id, version='draft').update(
         modified=timezone.now(), metadata=version.metadata