Skip to content

Commit

Permalink
Add note about additional cause of orphaned asset blobs
Browse files Browse the repository at this point in the history
  • Loading branch information
mvandenburgh committed Nov 6, 2023
1 parent 5f1301a commit eef6976
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion doc/design/garbage-collection-uploads-asset-blobs.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ If the user cancels a multipart upload partway through, or completes the multipa

### Orphaned AssetBlobs

In this case, assume that the user properly completes the multipart upload flow and “finalizes” the `Upload` record such that it is now an `AssetBlob`, but they do not send a request to associate the new blob with an `Asset`. That `AssetBlob` record and associated S3 object will remain in the database/bucket indefinitely.
In this case, assume that the user properly completes the multipart upload flow and “finalizes” the `Upload` record such that it is now an `AssetBlob`, but they do not send a request to associate the new blob with an `Asset`. That `AssetBlob` record and associated S3 object will remain in the database/bucket indefinitely. Also future `Asset` garbage collection implementation can be designed independently of logic to also clean up AssetBlobs, and we might end up with such orphaned `AssetBlobs` too to be picked up by this implementation.

Another potential cause of orphaned `AssetBlobs` could be `Asset` garbage collection itself. `Asset` garbage collection will be designed independently of the logic to clean up `AssetBlobs`, and running it might also result in orphaned `AssetBlobs`.

## Implementation

Expand Down

0 comments on commit eef6976

Please sign in to comment.