Fix Within an except clause, raise exceptions with `raise ... from …

…err` or `raise ... from None` to distinguish them from errors in exception handling

dandiapi/api/asset_paths.py

@@ -130,7 +130,7 @@ def insert_asset_paths(asset: Asset, version: Version):
         # If there are simultaneous requests to create the same asset, this check constraint can
         # fail, and should be handled directly, rather than be allowed to bubble up
         if 'unique-version-path' in str(e):
-            raise AssetAlreadyExists
+            raise AssetAlreadyExists from e
 
         # Re-raise original exception otherwise
         raise

dandiapi/api/management/commands/migrate_published_version_metadata.py

@@ -26,7 +26,7 @@ def migrate_published_version_metadata(dandiset: str, published_version: str, to
     except Exception as e:
         click.echo(f'Failed to migrate {dandiset}/{published_version}')
         click.echo(e)
-        raise click.Abort
+        raise click.Abort from e
 
     if metadata == metanew:
         click.echo('No changes detected')

dandiapi/api/views/auth.py

@@ -147,8 +147,8 @@ def user_questionnaire_form_view(request: HttpRequest) -> HttpResponse:
     try:
         # questions to display in the form
         questions = json.loads(request.GET.get('QUESTIONS'))
-    except (JSONDecodeError, TypeError):
-        raise Http404
+    except (JSONDecodeError, TypeError) as e:
+        raise Http404 from e
 
     return render(
         request,

dandiapi/api/views/dandiset.py

@@ -147,8 +147,8 @@ def get_object(self):
         lookup_url = self.kwargs[self.lookup_url_kwarg]
         try:
             lookup_value = int(lookup_url)
-        except ValueError:
-            raise Http404('Not a valid identifier.')
+        except ValueError as e:
+            raise Http404('Not a valid identifier.') from e
         self.kwargs[self.lookup_url_kwarg] = lookup_value
 
         dandiset = super().get_object()
@@ -383,8 +383,8 @@ def get_user_or_400(username):
                 else:
                     try:
                         return User.objects.get(username=username)
-                    except ObjectDoesNotExist:
-                        raise ValidationError(f'User {username} not found')
+                    except ObjectDoesNotExist as e:
+                        raise ValidationError(f'User {username} not found') from e
 
             owners = [
                 get_user_or_400(username=owner['username']) for owner in serializer.validated_data

dandiapi/api/views/upload.py

@@ -197,7 +197,7 @@ def upload_complete_view(request: Request, upload_id: str) -> HttpResponseBase:
     except Upload.DoesNotExist:
         upload = get_object_or_404(EmbargoedUpload, upload_id=upload_id)
         if not request.user.has_perm('owner', upload.dandiset):
-            raise Http404
+            raise Http404 from None
 
     completion = TransferredParts(
         object_key=upload.blob.name,
@@ -237,7 +237,7 @@ def upload_validate_view(request: Request, upload_id: str) -> HttpResponseBase:
     except Upload.DoesNotExist:
         upload = get_object_or_404(EmbargoedUpload, upload_id=upload_id)
         if not request.user.has_perm('owner', upload.dandiset):
-            raise Http404
+            raise Http404 from None
 
     # Verify that the upload was successful
     if not upload.object_key_exists():
@@ -275,7 +275,7 @@ def upload_validate_view(request: Request, upload_id: str) -> HttpResponseBase:
                 asset_blob = upload.to_asset_blob()
                 asset_blob.save()
             else:
-                raise ValueError(f'Unknown Upload type {type(upload)}')
+                raise ValueError(f'Unknown Upload type {type(upload)}') from None
 
         # Clean up the upload
         upload.delete()

dandiapi/zarr/views/__init__.py

@@ -138,8 +138,8 @@ def create(self, request):
         zarr_archive: ZarrArchive = ZarrArchive(name=name, dandiset=dandiset)
         try:
             zarr_archive.save()
-        except IntegrityError:
-            raise ValidationError('Zarr already exists')
+        except IntegrityError as e:
+            raise ValidationError('Zarr already exists') from e
 
         serializer = ZarrSerializer(instance=zarr_archive)
         return Response(serializer.data, status=status.HTTP_200_OK)