Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version in /server-info is "0+unknown" #1045

Closed
jwodder opened this issue Apr 20, 2022 · 4 comments · Fixed by #1054
Closed

version in /server-info is "0+unknown" #1045

jwodder opened this issue Apr 20, 2022 · 4 comments · Fixed by #1054
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@jwodder
Copy link
Member

jwodder commented Apr 20, 2022

https://dandiarchive.org/server-info currently returns a JSON object in which the "version" field has a value of "0+unknown". This causes a test failure in the dandi-cli code, as it has a test that depends on that field being greater than "1.2.0".

@jwodder jwodder added the bug Something isn't working label Apr 20, 2022
@jjnesbitt
Copy link
Member

https://dandiarchive.org/server-info currently returns a JSON object in which the "version" field has a value of "0+unknown". This causes a test failure in the dandi-cli code, as it has a test that depends on that field being greater than "1.2.0".

There will be a follow-up PR soon to address this, but the CLI test will need to change, since we'll be using the API version based on the latest release, instead of the hardcoded version 1.2.0.

@yarikoptic
Copy link
Member

I think it is a duplicate of good old #222 , so would be great to see it addressed indeed!

@dandibot
Copy link
Member

🚀 Issue was released in v0.2.18 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 29, 2022
@yarikoptic
Copy link
Member

I have reopened the original #222 since I do not see that it was fixed, but will keep this closed since they are AFAIK duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants