Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version in /api/info/ #1054

Merged
merged 18 commits into from
Apr 29, 2022
Merged

Fix version in /api/info/ #1054

merged 18 commits into from
Apr 29, 2022

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented Apr 20, 2022 •
edited
Loading

Closes #1045
Closes #222

I don't believe there's anything to do with the infrastructure, since this would change on each deploy, but I could be wrong.

Requesting more reviews than usual since this modifies our staging/prod deploy a bit.

This was referenced Apr 21, 2022
Closed
Open
yarikoptic
yarikoptic reviewed Apr 21, 2022
View reviewed changes
dev/.env.docker-compose Outdated Show resolved Hide resolved
@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 22, 2022
mvandenburgh
mvandenburgh requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new checkout action can be changed to just use the default token provided by github actions - see my comment below.

.github/workflows/update-release-branch.yml Outdated Show resolved Hide resolved
dchiquito
dchiquito reviewed Apr 22, 2022
View reviewed changes
dandiapi/api/views/info.py Show resolved Hide resolved
dandiapi/settings.py Outdated Show resolved Hide resolved
@jjnesbitt
Copy link
Member Author

Based on some out of band conversations, it looks like we're going to take a different approach to how we handle versioning. For the time being I'm going to mark this PR as draft until that's fleshed out.

@jjnesbitt jjnesbitt marked this pull request as draft April 22, 2022 20:02
@jjnesbitt
Copy link
Member Author

This PR has been updated to use setuptools_scm. This allows for the version to be computed determined by git as we intended. This still works in heroku as git info is still present when heroku pip installs our application.

@jjnesbitt jjnesbitt marked this pull request as ready for review April 22, 2022 20:45
@jjnesbitt jjnesbitt marked this pull request as draft April 28, 2022 19:25
@jjnesbitt jjnesbitt marked this pull request as ready for review April 29, 2022 20:20
@jjnesbitt jjnesbitt merged commit dd0ab84 into master Apr 29, 2022
@jjnesbitt jjnesbitt deleted the fix-version branch April 29, 2022 20:34
@dandibot
Copy link
Member

🚀 PR was released in v0.2.18 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 29, 2022
@jjnesbitt jjnesbitt mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@jwodder jwodder jwodder left review comments

@mvandenburgh mvandenburgh mvandenburgh requested changes

@dchiquito dchiquito dchiquito approved these changes

@waxlamp waxlamp Awaiting requested review from waxlamp

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version in /server-info is "0+unknown" /info: automated versioning by versioneer needs fixing
6 participants
@jjnesbitt @dandibot @yarikoptic @jwodder @dchiquito @mvandenburgh