Make checksum_worker responsible for zarr ingest #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
approved these changes
Apr 6, 2022
Currently zarr ingestion runs on the main task queue, which blocks other shorter tasks from running. Instead, have a separate `ingest_zarr_archive` queue which is consumed by the existing `checksum-worker`. Having a separate worker for blob checksums and zarr checksums seems like overkill to me, since we will almost never have a spike in both at the same time, and even if we did, the solution is to scale the number of `checksum-worker`s even higher.
dchiquito
force-pushed
the
ingest-zarr-task
branch
from
bdfb28b
to
f0cc205
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently zarr ingestion runs on the main task queue, which blocks other
shorter tasks from running. Instead, have a separate
ingest_zarr_archivequeue which is consumed by the existingchecksum-worker.Having a separate worker for blob checksums and zarr checksums seems
like overkill to me, since we will almost never have a spike in both at
the same time, and even if we did, the solution is to scale the number
of
checksum-workers even higher.