Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double-publishing #1006

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Prevent double-publishing #1006

merged 5 commits into from
Oct 6, 2022

Commits on Oct 5, 2022

  1. Add PUBLISHING status to Version.status choices

    @mvandenburgh
    mvandenburgh committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ffe74f9 View commit details
    Browse the repository at this point in the history

  2. Move publishing into a celery task

    @mvandenburgh
    mvandenburgh committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0a96f80 View commit details
    Browse the repository at this point in the history

  3. Improve publish button UX 

    - After clicking the publish button, display a loading indicator and poll the server to determine when the publishing is complete
- Once the publishing is complete, display a snackbar notification with a link to the newly published version
- If the publish button is clicked while a publish is ongoing, display an error message and begin polling for the publish to complete. Once completed, display a link to it.
    @mvandenburgh
    mvandenburgh committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    d6a7fc7 View commit details
    Browse the repository at this point in the history

  4. Update tests 

    - Add new test for publish task
- Modify publish rest test to only test for PUBLISHING status, not entire publish workflow
- Consolidate two publish REST endpoint tests into one
    @mvandenburgh
    mvandenburgh committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    1fa54ec View commit details
    Browse the repository at this point in the history

  5. Improve endpoint response, update test 

    Add specific error messages instead of returing "Dandiset metadata or asset metadata is not valid" everytime a publish can't occur
    @mvandenburgh
    mvandenburgh committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e0d8267 View commit details
    Browse the repository at this point in the history