BF(workaround): to avoid crash for user lacking metadata - return INCOMPLETE #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OMPLETE Underlying issue is somewhere in the logic/instructions so that locally created user lacks .metadata somehow, although it seems to be available within /admin interface among Users table for that user. So must be some glue missing etc. With this workaround it should still work ok, but would avoid crashing and due to INCOMPLETE I would expect that user lacking any super powers otherwise granted Workaround for #1085
yarikoptic
commented
May 6, 2022
| if metadata: | ||
| return metadata.status | ||
| logger.error("User %s lacks .metadata. Returning user's status as INCOMPLETE", user) | ||
| return UserMetadata.Status.INCOMPLETE |
There was a problem hiding this comment.
@djarecka make it here
Suggested change
| return UserMetadata.Status.INCOMPLETE | |
| return UserMetadata.Status.APPROVED |
if you want to allow that user to be able to click 'Create dataset' etc
|
since I keep getting annoyed to need this patch to do anything with local instance, I will merge this PR although a proper solution for #1085 is yet to be developed to populate |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying issue is somewhere in the logic/instructions so that locally created
user lacks .metadata somehow, although it seems to be available within /admin
interface among Users table for that user. So must be some glue missing etc.
With this workaround it should still work ok, but would avoid crashing
and due to INCOMPLETE I would expect that user lacking any super powers
otherwise granted
Note: pycharm checker highlights
.metadatasince it is not defined inUserclass at all. Is it indeed just ducktyped into it?Workaround for #1085