Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking the validation status, new attempt #1097

Merged
merged 2 commits into from
May 11, 2022

Conversation

djarecka
Copy link
Member

fixes #756

instead of #1092

checking if the validation status is Pending before proving the metadata error

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels May 11, 2022
@yarikoptic
Copy link
Member

what could go wrong? Added 'release' label, so we would release upon merge to see it in the glory on the main deployment as well to bring other changes in as well (@satra wants to see corrected total size)

Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @djarecka !

@yarikoptic yarikoptic merged commit 44c1524 into master May 11, 2022
@yarikoptic yarikoptic deleted the fix/pending_validation_new branch May 11, 2022 20:01
@dandibot
Copy link
Member

🚀 PR was released in v0.2.21 🚀

@dandibot dandibot added the released This issue/pull request has been released. label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show indicator of running validation job in DLP
3 participants