ENH: increase page size from 25 to 100 #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should result in x4 fold reduction of logs from such requests, speed up client interactions etc. Motivation: dandi/dandi-cli#1018
mvandenburgh
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
The web client specifies a page_size for the file browser, so that won't be an issue.
|
coolio, let's give it a shot then |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should result in x4 fold reduction of logs from such requests,
speed up client interactions etc.
Motivation: dandi/dandi-cli#1018
edit 1: possible "visible" side effect is 100 assets to be displayed per page in file navigator per dandiset. Might be considered pros or cons