Properly include "data packages" in project #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
requested changes
Jun 14, 2022
Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>
mvandenburgh
approved these changes
Jun 23, 2022
|
was approved and we indeed better test on staging but for that we need to merge. I will be the brave soul to press the green button |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several folders in
dandiapi/that contain data files but no Python source code, and we want these to be included when dandiapi is installed. Currently, these folders are automatically included by the combination ofgraft dandiapiinMANIFEST.inandinclude_package_data=Trueinsetup.py, but because we setpackagesinsetup.pytofind_packages()instead offind_namespace_packages(), the folders themselves are not recognized by setuptools as packages. This combination of settings is deprecated, and the setuptools developers recommend usingfind_namespace_packages()instead offind_packages()for such situations.