-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ngff rename script as a management command #1120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just one suggestion
@AlmightyYakob can you review the changes here? |
FWIW dandi move command could be used. See dandi/dandi-cli#1081 (comment) for an example with regex. |
Oh that might be a better option for this kind of operation than a management command. @satra requested that this script be committed to the repo, so I'll leave it up to him whether or not this should still be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we end up wanting to merge.
was the date for this PR birth... |
i think this is a more generic operation at the level of the database if necessary. i would keep it in the folder as an example of how to operate/rename on many assets, but most likely we will never use this specific script (there should be no ngff files moving forward). |
🚀 PR was released in |
Adds the script I wrote to rename .ngff files to .ome.zarr as a management command so we have it for future reference