Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ngff rename script as a management command #1120

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

mvandenburgh
Copy link
Member

Adds the script I wrote to rename .ngff files to .ome.zarr as a management command so we have it for future reference

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one suggestion

dandiapi/api/management/commands/rename_ngff.py Outdated Show resolved Hide resolved
@mvandenburgh
Copy link
Member Author

@AlmightyYakob can you review the changes here?

@yarikoptic
Copy link
Member

FWIW dandi move command could be used. See dandi/dandi-cli#1081 (comment) for an example with regex.

@mvandenburgh
Copy link
Member Author

FWIW dandi move command could be used. See dandi/dandi-cli#1081 (comment) for an example with regex.

Oh that might be a better option for this kind of operation than a management command. @satra requested that this script be committed to the repo, so I'll leave it up to him whether or not this should still be merged.

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we end up wanting to merge.

@yarikoptic
Copy link
Member

Jun 15

was the date for this PR birth... dandi move dandi/dandi-cli#1024 was initiated May 31st but merged into master of dandi-cli Jun 27 . I do feel that this PR is just no longer needed, but @satra might have different thoughts.

@satra
Copy link
Member

satra commented Jul 22, 2022

i think this is a more generic operation at the level of the database if necessary. i would keep it in the folder as an example of how to operate/rename on many assets, but most likely we will never use this specific script (there should be no ngff files moving forward).

@mvandenburgh mvandenburgh merged commit 221944f into master Jul 22, 2022
@mvandenburgh mvandenburgh deleted the add-ngff-rename-script branch July 22, 2022 22:04
@dandibot
Copy link
Member

🚀 PR was released in v0.2.39 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants