Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Present dialog if attempting to remove self from dandiset #1125

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Present dialog if attempting to remove self from dandiset #1125

merged 3 commits into from
Jul 25, 2022

Conversation

jjnesbitt
Copy link
Member

Closes #754

@jjnesbitt jjnesbitt force-pushed the 754-owner-self-removal branch 2 times, most recently from de33c69 to eefe94f Compare June 20, 2022 22:34
@mvandenburgh
Copy link
Member

I think the intent isn't to completely remove the ability for one to remove themselves as an owner, but that there should be some sort of confirmation prompt warning them before they go through with it.

@jjnesbitt jjnesbitt marked this pull request as draft June 22, 2022 18:01
@waxlamp
Copy link
Member

waxlamp commented Jun 22, 2022

I think the intent isn't to completely remove the ability for one to remove themselves as an owner, but that there should be some sort of confirmation prompt warning them before they go through with it.

This. I thought the title of #754 made this clear but perhaps not--if we need more discussion let's have it on that issue.

@jjnesbitt jjnesbitt closed this Jul 25, 2022
@jjnesbitt jjnesbitt reopened this Jul 25, 2022
@jjnesbitt jjnesbitt marked this pull request as ready for review July 25, 2022 18:09
@jjnesbitt jjnesbitt changed the title Prevent self removal from dandiset Present dialog if attempting to remove self from dandiset Jul 25, 2022
@jjnesbitt jjnesbitt requested review from mvandenburgh and removed request for mvandenburgh July 25, 2022 18:55
mvandenburgh
mvandenburgh requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some suggested style changes to keep the UI consistent with the existing DLP styling

web/src/components/DLP/DandisetOwnersDialog.vue Show resolved Hide resolved
web/src/components/DLP/DandisetOwnersDialog.vue Show resolved Hide resolved
@jjnesbitt @mvandenburgh
Remove button elevations
84a0c97 
Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>
mvandenburgh
mvandenburgh approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnesbitt jjnesbitt merged commit f13b5fc into master Jul 25, 2022
@jjnesbitt jjnesbitt deleted the 754-owner-self-removal branch July 25, 2022 19:58
@dandibot
Copy link
Member

🚀 PR was released in v0.2.40 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow self-removal from dandiset owners without a warning
4 participants
@jjnesbitt @mvandenburgh @waxlamp @dandibot