Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iteration instead of recursion in import_dandisets script #1150

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Use iteration instead of recursion in import_dandisets script #1150

merged 2 commits into from
Jul 7, 2022

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh
Use iteration instead of recursion in import_dandisets script
0002902 
Using recursion may lead to excessive memory usage with larger dandisets
Base automatically changed from add-assets-to-import-dandiset-script to master June 30, 2022 20:53
jjnesbitt
jjnesbitt requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code suggestions but looks good otherwise

dandiapi/api/management/commands/import_dandisets.py Outdated Show resolved Hide resolved
dandiapi/api/management/commands/import_dandisets.py Outdated Show resolved Hide resolved
dandiapi/api/management/commands/import_dandisets.py Outdated Show resolved Hide resolved
@mvandenburgh @jjnesbitt
Use previously defined var instead of repeating .get()
af22877 
Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
@mvandenburgh mvandenburgh merged commit 74a1a5d into master Jul 7, 2022
@mvandenburgh mvandenburgh deleted the import-dandisets-iteration branch July 7, 2022 19:11
@dandibot
Copy link
Member

dandibot commented Jul 7, 2022

🚀 PR was released in v0.2.34 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvandenburgh @dandibot @jjnesbitt