Fix race condition in sha256 calculation #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waits until the current transaction is commited before running asset validation. This fixes the race condition where asset validation occurs before the newly calculated sha256 checksum is commited to the DB
mvandenburgh
added
patch
jjnesbitt
approved these changes
Jul 6, 2022
danlamanna
approved these changes
Jul 7, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits until the current transaction is commited before running asset validation.
As part of the asset validation process, the sha256 checksum is injected into the metadata. The recent changes to delay asset validation to a new task after checksumming means that there is a good chance it will run before the sha256 checksum has been commited to the database. This PR uses the
transaction.on_commithook to avoid this. I also made a small memory optimization by changing aqueryset.valuesto aqueryset.values_list.Fixes #1156