Require metadata/asset schemaVersion #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
fix-schema-missing-version
branch
from
fff7582
to
a3d04da
Compare
|
@danlamanna #1212 fixed some issues with the CLI integration tests. They seem to be different than the ones you're encountering here, but it might be worth rebasing on |
danlamanna
force-pushed
the
fix-schema-missing-version
branch
2 times, most recently
from
1eb5138
to
c79f636
Compare
jjnesbitt
reviewed
Jul 26, 2022
dandiapi/api/migrations/0031_asset_asset_metadata_has_schema_version_and_more.py
Show resolved
Hide resolved
danlamanna
force-pushed
the
fix-schema-missing-version
branch
3 times, most recently
from
e6cdfcf
to
6d1b3de
Compare
mvandenburgh
reviewed
Aug 3, 2022
mvandenburgh
approved these changes
Aug 3, 2022
satra
reviewed
Aug 3, 2022
danlamanna
force-pushed
the
fix-schema-missing-version
branch
from
6d1b3de
to
b0d385e
Compare
danlamanna
force-pushed
the
fix-schema-missing-version
branch
from
b0d385e
to
2cee4ee
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1193 and #1117.
This makes schemaVersion required with a database constraint and patches up the primary place we weren't defaulting it to
settings.DANDI_SCHEMA_VERSION. I also merged two tests that were testing nearly identical things but had already started to drift apart. I'd like to review this with @mvandenburgh before merging.