Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-Duplicate API calls in DLP #1208

Merged
merged 6 commits into from
Aug 4, 2022
Merged

De-Duplicate API calls in DLP #1208

merged 6 commits into from
Aug 4, 2022

Conversation

DeepikaGhodki
Copy link
Contributor

@DeepikaGhodki DeepikaGhodki commented Jul 22, 2022 •
edited
Loading

Resolves #1166

  • Remove watchEffect
  • Set version count while fetching all versions instead of getting it from server
  • A new state called versionCount is added to facilitate this
  • Fetch the latest version (instead of fetching by count)

@DeepikaGhodki DeepikaGhodki changed the title Set version count when fetching all versions Duplicate API calls in DLP Jul 22, 2022
DeepikaGhodki
DeepikaGhodki commented Jul 22, 2022
View reviewed changes
web/src/rest.ts Outdated Show resolved Hide resolved
jjnesbitt
jjnesbitt requested changes Jul 22, 2022
View reviewed changes
web/src/rest.ts Outdated Show resolved Hide resolved
web/src/store/dandiset.ts Outdated Show resolved Hide resolved
@yarikoptic yarikoptic changed the title Duplicate API calls in DLP De-Duplicate API calls in DLP Jul 25, 2022
@DeepikaGhodki DeepikaGhodki marked this pull request as draft July 25, 2022 22:50
@DeepikaGhodki DeepikaGhodki requested review from jjnesbitt and removed request for mvandenburgh and jjnesbitt July 25, 2022 22:51
@DeepikaGhodki DeepikaGhodki marked this pull request as ready for review August 1, 2022 18:09
@DeepikaGhodki DeepikaGhodki merged commit e7799a8 into master Aug 4, 2022
@DeepikaGhodki DeepikaGhodki deleted the duplicate-api-calls branch August 4, 2022 17:09
@dandibot
Copy link
Member

🚀 PR was released in v0.2.43 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate DLP API calls
3 participants
@DeepikaGhodki @dandibot @jjnesbitt