Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata flag for asset listing #1216

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Add metadata flag for asset listing #1216

merged 4 commits into from
Jul 27, 2022

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented Jul 26, 2022

Closes #1217.

Addresses in part #397.

This specifically addresses the metadata flag for the asset list endpoint. If we want to address other aspects of that issue, they should be filed as their own respective issues.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions ;)

dandiapi/api/views/asset.py Outdated Show resolved Hide resolved
dandiapi/api/views/asset.py Outdated Show resolved Hide resolved
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I trust nobody, especially an assumption that developers would read all the docstrings thoroughly, I have left a suggestion and will leave another little one. But otherwise, in general, this PR looks ok'ish to me now

@yarikoptic
Copy link
Member

And thank you @AlmightyYakob for cooking it up so quickly!

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 27, 2022
@jjnesbitt jjnesbitt merged commit 4ab30ec into master Jul 27, 2022
@jjnesbitt jjnesbitt deleted the 397-asset-list branch July 27, 2022 20:30
@dandibot
Copy link
Member

🚀 PR was released in v0.2.41 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally include asset metadata in paginated asset listing
4 participants