Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset list performance issue #1222

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix asset list performance issue #1222

merged 1 commit into from
Aug 22, 2022

Conversation

danlamanna
Copy link
Contributor

Fix n+1 problem in the asset listing endpoint.

Partially addresses #1221.

mvandenburgh
mvandenburgh approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this fixes the immediate performance problems we're seeing, I think this is good to go and we can iterate on a followup PR to determine if more select_related calls are needed.

@danlamanna danlamanna merged commit 325090e into master Aug 22, 2022
@danlamanna danlamanna deleted the fix-asset-list-performance branch August 22, 2022 20:02
@dandibot
Copy link
Member

🚀 PR was released in v0.2.43 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlamanna @dandibot @yarikoptic @mvandenburgh