Clean up storage layer #1238
Merged
Clean up storage layer #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
refactor-storage-layer
branch
from
d64b1ec
to
bdc80d4
Compare
mvandenburgh
approved these changes
Aug 11, 2022
|
I want to wait to merge this until after #1220. |
danlamanna
force-pushed
the
refactor-storage-layer
branch
from
bdc80d4
to
c13a0ae
Compare
danlamanna
force-pushed
the
refactor-storage-layer
branch
from
c13a0ae
to
a914315
Compare
danlamanna
force-pushed
the
refactor-storage-layer
branch
from
a914315
to
411636c
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344.
This just moves storage operations to their storage backend instead of if/else switching throughout the rest of the codebase. This should make it easier to reason about the rest of the code, and allow us to see exactly which features we're using of S3/minio at a glance.