Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.10 #1247

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Require Python 3.10 #1247

merged 3 commits into from
Aug 22, 2022

Conversation

mvandenburgh
Copy link
Member

Updates our development environment and Heroku deployment to require the latest Python 3.10.

This will let us use new typing syntax like the X | Y union operator without having to "cheat" with from __future__ import annotations, in addition to all the other new features Python 3.10 introduces.

I've also run pyupgrade on the codebase to update to the latest syntax and remove deprecated code.

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd only ask to make sure that the updated dev containers works locally as well, since that isn't tested by CI (although maybe that's covered by the CLI tests, I'm not sure).

@mvandenburgh
Copy link
Member Author

LGTM, I'd only ask to make sure that the updated dev containers works locally as well, since that isn't tested by CI (although maybe that's covered by the CLI tests, I'm not sure).

Good catch. I recreated the dev containers locally and they work fine.

@mvandenburgh mvandenburgh merged commit 6664eaf into master Aug 22, 2022
@mvandenburgh mvandenburgh deleted the python-3.10 branch August 22, 2022 15:18
@dandibot
Copy link
Member

🚀 PR was released in v0.2.43 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants