Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assets path pagination #1253

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Update assets path pagination #1253

merged 2 commits into from
Aug 25, 2022

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented Aug 23, 2022

Closes #869

This change ensures that any query parameters are preserved upon pagination. To accomplish this, corresponding function has been reworked to more closely resemble the DRF pagination implementation.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Aug 25, 2022
@jjnesbitt jjnesbitt merged commit af677c7 into master Aug 25, 2022
@jjnesbitt jjnesbitt deleted the asset-paths-pagination branch August 25, 2022 19:24
@dandibot
Copy link
Member

🚀 PR was released in v0.2.43 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path api doesn't return well formatted url
3 participants