Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sentry performance for frontend #1270

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Enable sentry performance for frontend #1270

merged 2 commits into from
Sep 19, 2022

Conversation

mvandenburgh
Copy link
Member

No description provided.

@mvandenburgh mvandenburgh requested review from danlamanna and removed request for danlamanna September 8, 2022 00:25
@mvandenburgh mvandenburgh marked this pull request as draft September 8, 2022 13:47
Base automatically changed from fix-sentry-frontend to master September 8, 2022 14:38
@mvandenburgh mvandenburgh marked this pull request as ready for review September 19, 2022 17:49
@mvandenburgh mvandenburgh added the patch Increment the patch version when merged label Sep 19, 2022
@mvandenburgh mvandenburgh added the release Create a release when this pr is merged label Sep 19, 2022
jjnesbitt
jjnesbitt approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you tested this to ensure it comes through sentry correctly?

@mvandenburgh
Copy link
Member Author

LGTM, have you tested this to ensure it comes through sentry correctly?

Yes, I tested locally with the staging sentry DSN and it works

@mvandenburgh mvandenburgh merged commit 4389285 into master Sep 19, 2022
@mvandenburgh mvandenburgh deleted the sentry-performance-frontend branch September 19, 2022 19:45
@dandibot
Copy link
Member

🚀 PR was released in v0.2.49 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

@danlamanna danlamanna Awaiting requested review from danlamanna

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvandenburgh @dandibot @jjnesbitt