Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset unembargo method #1282

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix asset unembargo method #1282

merged 2 commits into from
Sep 22, 2022

Conversation

jjnesbitt
Copy link
Member

Closes #1264
Closes #1278

There were a couple of things wrong with the asset unembargo method

  1. The metadata wasn't saved, so the metadata remained out of date and incorrect
  2. The sha256 value wasn't copied to the unembargoed asset blob, leaving that field null.

@yarikoptic I believe the latter is the cause of #1278.

@yarikoptic
Copy link
Member

coolio! Thank you @AlmightyYakob . Note that "CI for backend / test" seems to be errorring out legitimately since in test_asset_unembargo[published]. botocore.exceptions.ClientError: An error occurred (404) when calling the HeadObject operation: Not Found so needs a look I guess.

mvandenburgh
mvandenburgh approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 22, 2022
@jjnesbitt jjnesbitt merged commit 9978b6e into master Sep 22, 2022
@jjnesbitt jjnesbitt deleted the 1264-asset-unembargo branch September 22, 2022 16:22
@dandibot
Copy link
Member

🚀 PR was released in v0.2.50 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assets can still be missing sha256, may be due to "unembargo" Asset metadata is not updated during unembargo
4 participants
@jjnesbitt @yarikoptic @dandibot @mvandenburgh