Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact prop consistently #1285

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Use exact prop consistently #1285

merged 2 commits into from
Sep 22, 2022

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Sep 20, 2022

Closes #792

Reviewers, please especially look at f4790be and tell me if that exact is actually supposed to be there in some other capacity (it has no corresponding :to, and doesn't look like it's supposed to).

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewers, please especially look at f4790be and tell me if that exact is actually supposed to be there in some other capacity (it has no corresponding :to, and doesn't look like it's supposed to).

I looks like it was placed there erroneously. The v-list-item-content docs make no mention of an exact prop.
https://vuetifyjs.com/en/api/v-list-item-content/

Copy link
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this comprehensively to be sure that all the appropriate places were covered, but the changes here seem reasonable.

There is a legitimate use case for to without exact, where nested pages should cause a top-level link to me marked as active. I don't know if that applies to any of these changes.

@waxlamp waxlamp merged commit 4da0128 into master Sep 22, 2022
@waxlamp waxlamp deleted the exact-prop branch September 22, 2022 18:20
@dandibot
Copy link
Member

dandibot commented Oct 4, 2022

🚀 PR was released in v0.2.51 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently use exact in router links
4 participants