Convert dandiset search test to jest/puppeteer, remove pyppeteer config from project #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
changed the title
mvandenburgh
force-pushed
the
convert-search-test-puppeteer
branch
from
ab79fe3
to
274b5d2
Compare
mvandenburgh
force-pushed
the
convert-search-test-puppeteer
branch
from
274b5d2
to
5a60d91
Compare
mvandenburgh
force-pushed
the
convert-search-test-puppeteer
branch
from
11d9beb
to
37c197b
Compare
danlamanna
reviewed
Oct 3, 2022
danlamanna
reviewed
Oct 3, 2022
danlamanna
approved these changes
Oct 3, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final test that needed to be converted to jest/puppeteer from pyppeteer. I also removed all configuration from CI and tox for pyppeteer.
Closes #995