Convert Meditor.vue to <script setup>
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were detected after converting to <script setup>
mvandenburgh
force-pushed
the
meditor-script-setup
branch
from
52437bb
to
437ee8c
Compare
mvandenburgh
commented
Oct 3, 2022
| @@ -57,18 +58,18 @@ | |||
| <template #activator="{ on }"> | |||
| <v-icon | |||
| left | |||
| :color="allModelsValid ? 'success' : 'error'" | |||
| :color="modelValid ? 'success' : 'error'" | |||
There was a problem hiding this comment.
Note, this was aliased as allModelsValid in the returned object of the original setup() function. Instead of replicating that behavior in the new <script> section, I think it's clearer to just use the modelValid variable directly.
There was a problem hiding this comment.
jjnesbitt
approved these changes
Nov 29, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.