Add Dandi exception classes #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
base-exceptions
branch
from
2e212bf
to
b1c2245
Compare
danlamanna
force-pushed
the
base-exceptions
branch
from
b1c2245
to
261fa5d
Compare
mvandenburgh
approved these changes
Nov 1, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds specific exceptions that the services module is going to start making use of. This is part of an effort to let our different contexts (celery, drf, cli, etc) catch errors and handle them appropriately.
I'm marking this as draft for the moment because I'd like to try it out on one or two subsequent PRs.