Optimize version/zarr asset path ingestion #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
asset-paths-ingest-performance
branch
2 times, most recently
from
260c50f
to
70c3117
Compare
jjnesbitt
force-pushed
the
asset-paths-ingest-performance
branch
from
70c3117
to
c9bb73c
Compare
waxlamp
approved these changes
Oct 26, 2022
|
I'd like to take a look at this more closely this afternoon. If it's urgent feel free to merge it now and I can revisit it later. |
danlamanna
reviewed
Oct 27, 2022
There was a problem hiding this comment.
I think managing transaction control by passing a boolean value around is a bit surprising. It's also wrapping the entire function body in a transaction, rather than isolating some specific portion of the logic, so it doesn't add much value to a caller. I think we should either drop the flag altogether, or determine which behavior ought to be conditional (bulk updating of AssetPaths or something like that).
jjnesbitt
force-pushed
the
asset-paths-ingest-performance
branch
from
1e01d0f
to
615865c
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks asset path ingestion in staging/prod. Previously, transactions were being used in such an inefficient way that ingestion would essentially halt.