Refactor asset create/update/delete #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
asset-services
branch
from
38dc555
to
da4f97d
Compare
jjnesbitt
requested changes
Nov 8, 2022
mvandenburgh
reviewed
Nov 8, 2022
danlamanna
force-pushed
the
asset-services
branch
2 times, most recently
from
0a0e7e8
to
60e025d
Compare
danlamanna
force-pushed
the
asset-services
branch
from
60e025d
to
566afeb
Compare
jjnesbitt
approved these changes
Nov 9, 2022
mvandenburgh
approved these changes
Nov 9, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general refactor of asset create/update/delete code. This PR doesn't alter any existing functionality, it just restructures the internal API.
@AlmightyYakob cc'ing you because this slightly touches asset path code