Internal publishing service #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
publish-service
branch
from
ced1433
to
7f79198
Compare
|
whoops I forgot to check if tests were passing before opening this... |
mvandenburgh
force-pushed
the
publish-service
branch
from
7f79198
to
b830d85
Compare
mvandenburgh
force-pushed
the
publish-service
branch
2 times, most recently
from
a77bb8c
to
24f9758
Compare
jjnesbitt
requested changes
Nov 14, 2022
danlamanna
reviewed
Nov 15, 2022
dandiapi/api/tests/test_version.py
Outdated
| @@ -654,8 +654,8 @@ def test_version_rest_publish_zarr( | |||
| f'/api/dandisets/{draft_version.dandiset.identifier}' | |||
| f'/versions/{draft_version.version}/publish/' | |||
| ) | |||
| assert resp.status_code == 400 | |||
| assert resp.json() == ['Cannot publish dandisets which contain zarrs'] | |||
| assert resp.status_code == 403 | |||
There was a problem hiding this comment.
Just a reminder to back out this one change we discussed.
mvandenburgh
force-pushed
the
publish-service
branch
2 times, most recently
from
2a753df
to
4e2c10c
Compare
Yeah I'm still not completely happy with how that turned out :( |
mvandenburgh
force-pushed
the
publish-service
branch
from
ac75bf5
to
16589bf
Compare
danlamanna
approved these changes
Nov 17, 2022
jjnesbitt
approved these changes
Nov 17, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors publishing into a service layer module.